Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Storybook for Next.js and Tailwind CSS #8

Merged
merged 10 commits into from
May 19, 2024

Conversation

hee-suh
Copy link
Member

@hee-suh hee-suh commented May 17, 2024

Issue Number

#2

Description

구현 내용 및 작업한 내용

  • Storybook for Next.js 를 이용해서 Storybook을 설치했습니다.
  • module aliases, svgr, tailwind css, RSC, 접근성 체크가 가능하게 설정했습니다.
  • PR 템플릿이랑 라벨러도 업데이트했습니다.

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

hee-suh added 8 commits May 17, 2024 20:18
(Experimental) If your app uses React Server Comp
onents (RSC), Storybook can render them in stories in
 the browser.

Setting this flag automatically wraps your story in a Suspense wrapper, which is able to render asynchronous components in NextJS's version of React.

If this wrapper causes problems in any of your existing stories, you can selectively disable it using the react.rsc parameter at the global/component/story level
Copy link
Member

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 깔끔~~

image

src/stories/Button.tsx Show resolved Hide resolved
Copy link
Contributor

@Pridesd Pridesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

접근성 테스트는 좀 신기하네요 ㅋㅋ 고생하셨습니다~~

.storybook/preview.ts Show resolved Hide resolved
@hee-suh hee-suh added the config label May 19, 2024
@hee-suh hee-suh merged commit 4692821 into main May 19, 2024
@hee-suh hee-suh deleted the feature/storybook-scaffold branch May 19, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants