feat: add new icons for CSS

[aixegorri]

Description

Added the official new logos for CSS to the icon set.

Closes: #2716

Contribution Guidelines

• By creating this pull request, I acknowledge that I have read the Contribution Guidelines for this project
• I have read the Code Of Conduct and promise to abide by these rules

[github-actions]

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

[okineadev]

These icons go well with the JS and TS icons, but I think it will be difficult to get used to them...

[okineadev]

I also think that they should be lighter, because they are too dark on a dark background, and too contrasting on a light one

[mallowigi]

They are so ugly. In my opinion it will be detrimental to the main purpose of the pack, which is to help visual distinction. We already have JS and TS that look alike, and now css?

[aixegorri]

They are so ugly. In my opinion it will be detrimental to the main purpose of the pack, which is to help visual distinction. We already have JS and TS that look alike, and now css?

We are not arguing whether the new logo is ugly or pretty. This is the new official CSS logo and soon everyone will associate it with the language. It would be nice to use a new icon that connects with the new image.

[okineadev]

They are so ugly. In my opinion it will be detrimental to the main purpose of the pack, which is to help visual distinction. We already have JS and TS that look alike, and now css?

See https://en.m.wikipedia.org/wiki/CSS

[okineadev]

I think it is necessary to create a mass forced vote for the best icon among all users of this extension in order to decide whether it is necessary to add a new icon

[okineadev]

A notification should pop up that cannot even be closed

[iTzNao]

Im personally loving the new logo! Here it is in a mock Next.js project!

[okineadev]

Im personally loving the new logo! Here it is in a mock Next.js project!

It's actually pretty hard to tell that it's a CSS icon...

[iTzNao]

Im personally loving the new logo! Here it is in a mock Next.js project!

It's actually pretty hard to tell that it's a CSS icon...

I mean, I personally look at the colours, and I really like the look.

[iTzNao]

Here is a look at it in tabs:

[okineadev]

Not halal

[okineadev]

Because the letters on the icon are not visible

[lucas-labs]

I opened #2716 a few days ago but didn't create a PR anticipating this change was going to be controversial.

IMO, It's still too early. The icon is just too new and if we merge this, we will have dozens of issues with the title "CSS icon broken". I would wait some time until the icon is more widely adopted and people is more familiar with it.

Also, I agree that the color doesn't play well with dark themes.

[lucas-labs]

I think it is necessary to create a mass forced vote for the best icon among all users of this extension in order to decide whether it is necessary to add a new icon
A notification should pop up that cannot even be closed

@okineadev I wouldn't do that. This pack is probably top-20 most installed extensions in vscode (26 million downloads). And not all users of this pack care about a css icon. If your main language is rust or cpp or zig, you don't want an imposible-to-close popup asking about css.

[okineadev]

I think it is necessary to create a mass forced vote for the best icon among all users of this extension in order to decide whether it is necessary to add a new icon
A notification should pop up that cannot even be closed

@okineadev I wouldn't do that. This pack is probably top-20 most installed extensions in vscode (26 million downloads). And not all users of this pack care about a css icon. If your main language is rust or cpp or zig, you don't want an imposible-to-close popup asking about css.

I don't care if they are interested in the CSS or not, we need public opinion!

(Actually, I'm writing this to troll Elior 😅)

[mallowigi]

In my plugin whenever there is a huge change like in angular for example, I always provide both icons. Unless the previous icon was ugly (like the previous yaml, the previous perl).

[mi2ebi]

looks a bit too dark to be readable imo

[iTzNao]

I mean, it is the official logo for CSS now, I personally don't like the SQLite logo but it is still the logo.

[iTzNao]

In my plugin whenever there is a huge change like in angular for example, I always provide both icons. Unless the previous icon was ugly (like the previous yaml, the previous perl).

You could make an option to change it in the config to the old logo, like css-old or something, making this will enable the project to have alternate logos in the future too! Thumbs up from me 👍

[mi2ebi]

I mean, it is the official logo for CSS now, I personally don't like the SQLite logo but it is still the logo.

accessibility is my point, rather than aesthetics

[rafaroldan93]

Well, I find this elegant and consistent:

I think it could be improved by coloring the text white and enlarging it a bit. Maybe also using more saturated colors to improve the contrast in dark themes.

[mi2ebi]

yep that works :)

[mi2ebi]

that's fine

[JaviRamosLab]

great solution, and is ok in the official site https://github.com/CSS-Next/logo.css