Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expectation of product #1391

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

expectation of product #1391

wants to merge 4 commits into from

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Nov 13, 2024 •
edited
Loading

Motivation for this change
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Nov 13, 2024
@affeldt-aist affeldt-aist added this to the 1.7.0 milestone Nov 13, 2024
@affeldt-aist
Copy link
Member Author

Maybe it is better to rename expectation_prod to expectation_mul since the original intent was expectationM.

@affeldt-aist affeldt-aist modified the milestones: 1.7.0, 1.8.0 Nov 22, 2024
@affeldt-aist affeldt-aist marked this pull request as draft December 3, 2024 05:42
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 2 times, most recently from 0895272 to bc59196 Compare December 3, 2024 06:03
@affeldt-aist affeldt-aist mentioned this pull request Dec 3, 2024
Merged
2 tasks
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 2 times, most recently from 538b914 to d32696d Compare December 3, 2024 07:12
t6s
t6s reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed lines 0 -- 878 and quickly looked through 879-.
The latter things need some cleaning.

theories/independence.v Outdated Show resolved Hide resolved
theories/independence.v Outdated Show resolved Hide resolved
theories/independence.v Show resolved Hide resolved
theories/independence.v Outdated Show resolved Hide resolved
theories/independence.v Outdated Show resolved Hide resolved
theories/independence.v Outdated Show resolved Hide resolved
theories/independence.v Outdated Show resolved Hide resolved
theories/independence.v Outdated Show resolved Hide resolved
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 5 times, most recently from 0ab14bf to a1eb371 Compare December 4, 2024 09:09
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 2 times, most recently from aabd8b3 to a811b46 Compare December 18, 2024 22:43
@affeldt-aist affeldt-aist modified the milestones: 1.8.0, 1.9.0 Dec 18, 2024
@affeldt-aist affeldt-aist force-pushed the probability_20241105 branch 3 times, most recently from f1b80c8 to a93338c Compare January 10, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t6s t6s t6s left review comments

@proux01 proux01 Awaiting requested review from proux01

@hoheinzollern hoheinzollern Awaiting requested review from hoheinzollern

Assignees
No one assigned
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@affeldt-aist @t6s