Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash at the end of identity server #1898

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

NicolasBuquet
Copy link
Contributor

@NicolasBuquet NicolasBuquet commented Jan 14, 2025

Old Account data can have a trailing slash at the end of their Identity Server.
This can lead to unrecognized URL on the backend (like on 'invite to room') because the URL is then constructed with a double slash in its path.
This leads to backend error 500 for these calls.
So, fix this trailing slash as soon as we receive i

Pull Request Checklist

@NicolasBuquet
Copy link
Contributor Author

@pixlwave @giomfo
Can you have a quick look at this PR?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.91%. Comparing base (1c4b3f5) to head (3807109).
Report is 70 commits behind head on develop.

Files with missing lines Patch % Lines
MatrixSDK/MXSession.m 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1898      +/-   ##
===========================================
+ Coverage    19.21%   19.91%   +0.70%     
===========================================
  Files          617      564      -53     
  Lines        97349    79304   -18045     
  Branches     40896    33432    -7464     
===========================================
- Hits         18701    15795    -2906     
+ Misses       78102    63493   -14609     
+ Partials       546       16     -530     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants