Move receipt-specific logic into ReceiptAccumulator #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
changed the title
andybalaam
changed the title
andybalaam
requested review from
dbkr and
justjanne
and removed request for
a team
Base automatically changed from
andybalaam/factor-out-receipt-accumulator
to
develop
April 26, 2023 15:31
weeman1337
approved these changes
Apr 27, 2023
src/sync-accumulator.ts
Outdated
| }; | ||
| }; | ||
| }; | ||
| _receipts: ReceiptAccumulator; |
There was a problem hiding this comment.
Is this really something that should be exposed via the interface?
It looks more like implementation specific to me.
There was a problem hiding this comment.
I didn't want to mess around with the design of the sync accumulator more than I needed to. I haven't really thought about what this interface actually does - let's discuss it sometime.
andybalaam
force-pushed
the
andybalaam/more-code-in-receipt-accumulator
branch
from
de9a4b3 to
80903de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#24629
Move all the logic for processing receipts into the ReceiptAccumulator, so we can create simpler tests, and so it's easier to deal with when we start fixing bugs in it.
It's probably worth looking at this commit-by-commit.
This change is marked as an internal change (Task), so will not be included in the changelog.