Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish room state and timeline events in embedded clients #4574

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

robintown
Copy link
Member

@robintown robintown commented Dec 6, 2024

This change enables room widget clients to take advantage of the more reliable method of communicating room state over the widget API provided by this update to MSC2762.

Depends on matrix-org/matrix-widget-api#116

This change enables room widget clients to take advantage of the more reliable method of communicating room state over the widget API provided by a recent update to MSC2762.
@robintown robintown marked this pull request as ready for review December 17, 2024 21:31
@robintown robintown requested a review from a team as a code owner December 17, 2024 21:31
@robintown robintown requested review from dbkr and t3chguy December 17, 2024 21:31
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this already. Can you still explain me why we don't need the await (or add it in case we need it)

src/embedded.ts Outdated Show resolved Hide resolved
@robintown robintown requested a review from a team as a code owner January 15, 2025 18:04
@robintown robintown added this pull request to the merge queue Jan 15, 2025
Merged via the queue into matrix-org:develop with commit bdd4d82 Jan 15, 2025
30 of 31 checks passed
@robintown robintown deleted the embedded-state branch January 15, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants