Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update matrix-sdk-crypto-wasm to 12.0.0 #4589

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Update matrix-sdk-crypto-wasm to 12.0.0 #4589

merged 1 commit into from
Dec 17, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented Dec 17, 2024

It appears to "just work"... but I might be missing something

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@hughns
Update matrix-sdk-crypto-wasm to 12.0.0
2faf098 
It appears to "just work"... but I might be missing something
@hughns hughns added T-Task Tasks for the team like planning Dependencies Pull requests that update a dependency file labels Dec 17, 2024
@hughns hughns marked this pull request as ready for review December 17, 2024 06:59
@hughns hughns requested a review from a team as a code owner December 17, 2024 06:59
@hughns hughns mentioned this pull request Dec 17, 2024
Closed
richvdh
richvdh approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, should be good. The only breaking change was making sure that we call initAsync, which matrix-js-sdk does.

@richvdh richvdh added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@hughns hughns added this pull request to the merge queue Dec 17, 2024
Merged via the queue into develop with commit e4182eb Dec 17, 2024
38 of 39 checks passed
@hughns hughns deleted the hughns/crypto-wasm-v12 branch December 17, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@richvdh richvdh richvdh approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-team

@uhoreg uhoreg Awaiting requested review from uhoreg

Assignees
No one assigned
Labels
Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughns @richvdh @t3chguy