Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatrixRTC: additional TS docs for IMembershipManager interface #4613

Merged
merged 3 commits into from
Jan 13, 2025
Merged

MatrixRTC: additional TS docs for IMembershipManager interface #4613

merged 3 commits into from
Jan 13, 2025
+22 −5

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jan 13, 2025

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

hughns
hughns requested changes Jan 13, 2025
View reviewed changes
src/matrixrtc/MembershipManager.ts Outdated Show resolved Hide resolved
src/matrixrtc/MembershipManager.ts Outdated Show resolved Hide resolved
src/matrixrtc/MembershipManager.ts Outdated Show resolved Hide resolved
@hughns hughns added T-Task Tasks for the team like planning and removed T-Enhancement labels Jan 13, 2025
@hughns hughns changed the title docstrings for IMembershipManager interface MatrixRTC: additional TS docs for IMembershipManager interface Jan 13, 2025
@hughns hughns marked this pull request as ready for review January 13, 2025 18:29
@hughns hughns requested a review from a team as a code owner January 13, 2025 18:29
@hughns hughns requested a review from robintown January 13, 2025 18:29
@hughns hughns added this pull request to the merge queue Jan 13, 2025
Merged via the queue into develop with commit f22d5e9 Jan 13, 2025
30 checks passed
@hughns hughns deleted the toger5/rtc-sessionmanager-move-docstring branch January 13, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughns hughns hughns approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-call-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toger5 @hughns