This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add unread fallback logging #10509
Merged
Add unread fallback logging #10509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeman1337
added
the
T-Task
|
@andybalaam @justjanne what do you think about this change? Is the new case being logged here something that should not happen regularly? Would logging this make sense? I want to avoid to add more logging without a good reason. |
justjanne
approved these changes
Apr 5, 2023
|
The more, the merrier :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#24629
We have no clue what is going on. Maybe logging the fallback case would make sense.
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.