Spec for MSC3981 #1746
Merged
Spec for MSC3981 #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This writes up matrix-org/matrix-spec-proposals#3981 Hopefully this is relatively straightforward, apart from having to add the parameters and response field in all three places. I tried to factor these out but it seems references just aren't supported in the right places currently (see #1745 for my efforts). Path parameters can't be optional, so it can't be done that way either.
|
I think I've fixed #1745, so let's hang fire hire for a minute |
|
Updated with ref version |
richvdh
approved these changes
Mar 19, 2024
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Note this is counter what the MSC actually proposed to add, but I think it's clear that this is what it meant.
turt2live
reviewed
Mar 19, 2024
| @@ -0,0 +1 @@ | |||
| Add support for recursion on the /relations endpoints (MSC3981). | |||
There was a problem hiding this comment.
I've applied the change to main as part of release checklist steps, but for future PRs please use a consistent changelog style (and apologies if these aren't documented anywhere - we should fix that if undocumented).
- Use backticks around endpoints, and indicate the request method.
- Use
, as per [MSC3981](...).at the end of your changelog, linking to the MSC in question.
Add support for recursion on the `GET /relations` endpoints, as per [MSC3981](https://github.com/matrix-org/matrix-spec-proposals/pull/3981).
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This writes up matrix-org/matrix-spec-proposals#3981
Hopefully this is relatively straightforward, apart from having to add the parameters and response field in all three places. I tried to factor these out but it seems references just aren't supported in the right places currently (see #1745 for my efforts). Path parameters can't be optional, so it can't be done that way either.Preview: https://pr1746--matrix-spec-previews.netlify.app