Improve loading performance #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build the list Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all a disclaimer that all tests and profiles had been done with Chromium "Version 131.0.6778.204 (Offizieller Build) Fedora Project (64-Bit)" and not firefox.
The before profile has been done using https://matrix-org.github.io/tardis/ and the after using a debug build.
Before the changes the redraw method on my pc took ~
22802.8ms. After the changes I am getting ~9583.5ms. This is rougly an improvement of 58%There only was a visual comparison on correctness however. I strongly think there have been no changes in behaviour of the code however I sugest having a good read :)
The profiles and the file used for testing can be found here https://cloud.midnightthoughts.space/s/yWfniCMFZ7xA99w (size limit of github exceeded. Its my nextcloud)