This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
📈 Elliptic Curve and Modexp Precompiles #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZamDimon
changed the title
jules
reviewed
May 25, 2024
vladbochok
reviewed
May 27, 2024
src/precompiles/ecmul.rs
Outdated
| // and validating that the conversion is successful | ||
| let x1_field = Fq::from_str(x1.to_string().as_str()).ok_or(Error::msg("invalid x1"))?; | ||
| let y1_field = Fq::from_str(y1.to_string().as_str()).ok_or(Error::msg("invalid y1"))?; | ||
| let s_field = Fr::from_str(s.to_string().as_str()).ok_or(Error::msg("invalid s"))?; |
There was a problem hiding this comment.
Why is that? s can be an arbitrary uint256 number
There was a problem hiding this comment.
True, missed that, we will update
There was a problem hiding this comment.
Yeah, indeed, missed that. Now, s can be arbitrary. Also, I added three different tests where the scalar is greater than the group order to make sure we have not missed anything
NikitaMasych
force-pushed
the
feature/ec-and-modexp-precompiles
branch
from
65c274c to
8ad9745
Compare
NikitaMasych
force-pushed
the
feature/ec-and-modexp-precompiles
branch
from
8ad9745 to
245965b
Compare
|
Fixed the issue where the point at infinity was encoded as a tuple According to the precompile spec, the point at infinity is now encoded as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This pull request adds the evm abstractions for the following precompiles:
ecadd: adding two points on the elliptic curve;ecmul: multiplying two points on the elliptic curve;ecpairing: verification of pairing operation;modexp: modular exponentiation.Why ❔
They haven't been implemented yet, thus the PR.
Checklist
zk fmtandzk lint.