This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Compiler tests interface #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xVolosnikov
reviewed
Jun 4, 2024
| @@ -57,6 +57,7 @@ pub fn run< | |||
| ) -> ( | |||
| SchedulerCircuitInstanceWitness<MainField, CircuitGoldilocksPoseidon2Sponge, GoldilocksExt2>, | |||
| BlockAuxilaryOutputWitness<MainField>, | |||
| S, | |||
There was a problem hiding this comment.
This function is used here:
Maybe changed interface will cause problems there
There was a problem hiding this comment.
Actually imo it is better to customize run_vms instead of this function and use it in compiler_tests_runner.rs
There was a problem hiding this comment.
Yeah, makes sense, I was thinking that this function is used only for the tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.