Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(state_keeper): switch from milliseconds to seconds in time utils #3463

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(state_keeper): switch from milliseconds to seconds in time utils #3463

wants to merge 2 commits into from
+3 −4

Conversation

VolodymyrBg
Copy link

@VolodymyrBg VolodymyrBg commented Jan 11, 2025 •
edited
Loading

  • Renamed millis_since_epoch() to seconds_since_epoch()
  • Changed time representation from milliseconds to seconds
  • Updated millis_since() to work with seconds while maintaining its interface

What ❔

  • Renamed millis_since_epoch() to seconds_since_epoch()
  • Changed time representation from milliseconds to seconds
  • Updated millis_since() to work with seconds while maintaining its interface
  • Improved type safety by using u64 instead of u128

Why ❔

Resolves SMA-1206

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@VolodymyrBg
refactor(state_keeper): switch from milliseconds to seconds in time u…
50fa51d 
…tils

Resolves SMA-1206

- Renamed millis_since_epoch() to seconds_since_epoch()
- Changed time representation from milliseconds to seconds
- Updated millis_since() to work with seconds while maintaining its interface
- Improved type safety by using u64 instead of u128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VolodymyrBg