feat(contract-verifier): Partial matching & automatic verification #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
force-pushed
the
popzxc-contract-verifier
branch
4 times, most recently
from
2a0083d to
44aac98
Compare
popzxc
force-pushed
the
popzxc-contract-verifier
branch
from
44aac98 to
514900f
Compare
popzxc
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88,
iluwaa,
vasyl-ivanchuk,
slowli and
perekopskiy
popzxc
commented
Jan 24, 2025
Comment on lines
+249
to
+250
| #[serde(default, skip_serializing_if = "Vec::is_empty")] | ||
| pub verification_problems: Vec<VerificationProblem>, |
There was a problem hiding this comment.
The side effect here is that if BE front-end won't be updated together with this change, the partially verified contracts will render as "fully verified" ones. However, the risk here is not great (and we will communicate this update to partners), so IMHO it's better than a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3190
Fixes #3309
I still have to test the migration logic (want to make sure that Era mainnet data can be migrated correctly & quickly), but the PR is reviewable otherwise.
This one is much bigger than I indended it to be, sorry 🥲
zksolcused in contract verifier tests to 1.5.10 (old one didn't haveipfsmetadata hash support).Yulbytecode extraction).