-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer Object.assign to $.extend to merge objects #209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code appears to replace usage of $.extend
with Object.assign
correctly, however I would like to defer final approval to additional persons with more experience in these arts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Although
Object.assign
and$.extend
have some differences (https://stackoverflow.com/questions/38345937/object-assign-vs-extend), the should not apply to us, as 1) we do not use thedeep: true
option in these methods, and 2) we are always merging in an empty object ({}
), so it should never be undefined.