Remove direct dependency on gulp-util #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanw88
changed the title
diclophis
approved these changes
Aug 29, 2024
diclophis
reviewed
Aug 29, 2024
| @@ -43,7 +44,7 @@ if (typeof options.grep === 'string') { | |||
|
|
|||
| const karmaErrorHandler = function(code) { | |||
| if (code === 1) { | |||
| util.log(util.colors.red('Tests finished with failures.')); | |||
| log(colors.red('Tests finished with failures.')); | |||
There was a problem hiding this comment.
If we just did console.log('Tests finished with failures.') could we remove fancy-log and ansi-colors npm packages?
There was a problem hiding this comment.
Yeah, those packages are just used for syntax highlighting.
There was a problem hiding this comment.
We still use log in the build-module step though, so will need to figure out how to eliminate that piece.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated
gulp-utilas per https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5