Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ox 3256 wrap brainstem js" #229

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

guanw88
Copy link
Contributor

@guanw88 guanw88 commented Aug 30, 2024

Reverts #223.

This results in bundle errors when attempting to compile mavenlink-js via node 20.

27 08 2024 22:48:08.008:ERROR [framework.browserify]: bundle error
27 08 2024 22:48:08.00[9](https://github.com/mavenlink/mavenlink-js/actions/runs/10587000984/job/29336886421?pr=702#step:5:10):ERROR [framework.browserify]: Error: Can't walk dependency graph: Cannot find module './utility-functions' from '/home/runner/work/mavenlink-js/mavenlink-js/node_modules/brainstem-js/lib/model.js'
    required by /home/runner/work/mavenlink-js/mavenlink-js/node_modules/brainstem-js/lib/model.js
27 08 2024 22:48:08.027:ERROR [framework.browserify]: bundle error
27 08 2024 22:48:08.028:ERROR [framework.browserify]: Error: Can't walk dependency graph: Cannot find module './utility-functions' from '/home/runner/work/mavenlink-js/mavenlink-js/node_modules/brainstem-js/lib/collection.js'
    required by /home/runner/work/mavenlink-js/mavenlink-js/node_modules/brainstem-js/lib/collection.js
27 08 2024 22:48:08.029:ERROR [framework.browserify]: bundle error
27 08 2024 22:48:08.030:ERROR [framework.browserify]: Error: Can't walk dependency graph: Cannot find module './utility-functions' from '/home/runner/work/mavenlink-js/mavenlink-js/node_modules/brainstem-js/lib/storage-manager.js'
    required by /home/runner/work/mavenlink-js/mavenlink-js/node_modules/brainstem-js/lib/storage-manager.js

https://github.com/mavenlink/mavenlink-js/actions/runs/10587000984/job/29336886421?pr=702

@guanw88
Copy link
Contributor Author

guanw88 commented Aug 30, 2024

I'm going to try tweaking the browserify settings in mavenlink-js but going to keep this around as a backup.

@guanw88 guanw88 merged commit 4da0aac into master Aug 30, 2024
1 check passed
@guanw88 guanw88 deleted the revert-223-ox-3256-wrap-brainstem-js branch August 30, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants