DO NOT MERGE: Fix redirectable with blank uris #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Calling public method redirectable should do the right thing regardless of validation state Signed-off-by: Kevin Lai <[email protected]> Co-authored-by: Kevin Lai <[email protected]>
|
Thinking about closing this PR, but we are actively using it in our bigmaven gemfile and I cannot risk someone accidentally coming back here to delete it. |
|
That commit looks like it's been rolled up into this PR and comment https://github.com/doorkeeper-gem/doorkeeper/pull/1277/files#r310095549 As soon as we get to Ruby 2.4/2.7 we should consider upgrading. @jhmoore Is there anything we can do to limit access to this fork or prevent merging while this gets worked on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR starts from Doorkeeper 5.0.2 as a base. This is intended to serve as a temporary source for our gem in the interim while we upgrade to Ruby 2.4+. This branch is pointed to from our gemfile, do not merge this PR!
Summary
We are fixing
redirectable?returning the wrong result as a consequence of a different error name type. This should function correctly independently of error name type.In base Doorkeeper, there is a PR and commit that the maintainer is looking to push into the latest 5.2 that fixes the issue in one way doorkeeper-gem@444fdbe where their intent is that validations (and the error response generated) need to happen in a very specific order and would avoid running into this issue.