Merge pull request #2322 from mavlink/pr-sonar-fixes

Sonarcloud warnings

src/mavsdk/core/inflate_lzma.cpp

@@ -112,6 +112,15 @@ static bool decompress(lzma_stream* strm, const char* inname, FILE* infile, FILE
 
             if (ferror(infile)) {
                 fprintf(stderr, "%s: Read error: %s\n", inname, strerror(errno));
+                // SonarCloud: Address of stack memory associated with local
+                // variable 'inbuf' is still referred to by the stack variable
+                // 'strm' upon returning to the caller. This will be a
+                // dangling reference
+                // Fixed by setting to nullptr.
+                strm->next_in = nullptr;
+                strm->avail_in = 0;
+                strm->next_out = nullptr;
+                strm->avail_out = 0;
                 return false;
             }
 
@@ -264,4 +273,4 @@ bool InflateLZMA::inflateLZMAFile(
     lzma_end(&strm);
 
     return success;
-}
+}

src/mavsdk/core/mavlink_ftp_client.h

@@ -221,7 +221,7 @@ class MavlinkFtpClient {
 
     struct Work {
         Item item;
-        PayloadHeader payload; // The last payload saved for retries
+        PayloadHeader payload{}; // The last payload saved for retries
         unsigned retries{RETRIES};
         bool started{false};
         Opcode last_opcode{};