Vitepress build #2490
Draft
Vitepress build #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hamishwillee
force-pushed
the
vitepress_build
branch
from
17df0da to
b497fe3
Compare
|
julianoes
reviewed
Jan 24, 2025
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Suggested change
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-24.04 |
I like to pin them, so they don't change from under you.
Comment on lines
+34
to
+35
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile |
There was a problem hiding this comment.
Can we move the package.json, package-lock.json and yarn.lock files into docs? I'd like not to "pollute" the root if possible.
|
|
||
|
|
||
| # vitepress - Docs guide | ||
| node_modules/ |
There was a problem hiding this comment.
Would be nice if we can move the node_modules into docs.
Comment on lines
+151
to
+154
| { | ||
| text: "v2", | ||
| link: "https://mavsdk.mavlink.io/v2.0/en/cpp/api_changes.html", | ||
| }, |
There was a problem hiding this comment.
I will create v3 and we should add it here, because main won't be v3 forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is vitepress build from mavlink/MAVSDK-docs#292 adjusted to deploy from MAVSDK repo. It adds the docs to build into
/docs/tree.Still to do
Not doing
This can be tested locally by cloning, then from root doing:
Then view in browser.