Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Invalid argument exception in camera plugin #2498

Closed
wants to merge 1 commit into from

Conversation

persuader72
Copy link
Contributor

Fix for Issue 2495

@persuader72
Copy link
Contributor Author

I see that some test are failing

I can't understand the real purpose of get_option_str method.

Reading from source code it would seem that the function will return the option name and return true if the option name is present in the list,

But the tests are expecting that the function will return the option name and return true if the option value is present in the list.

Do you know what is the correct purpose?

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julianoes
Copy link
Collaborator

Can you look into the unit tests? Somehow it makes them fail...

@persuader72
Copy link
Contributor Author

Hi

I tried to understand better the flow of get_option_str function i now i think that function is correct, maybe the variable names inside it are a little misleading but it is correct.

The function take in input an option value and return the option name is it exists.

I close di PR because i have to look for the cause of the Invalid argument exception somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants