Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the ResidueResult name attribut #1

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

nbruciaferri
Copy link
Contributor

I was working with the rust-sasa-python to extract sasa at the residue level and I found that it would be useful to return a vector of tuples with the residue name and the sasa calculated to allow an easy mapping of the residues and their sasa.

The name of the residues is a combination of chainID-resname-resnum.

Hope this makes sense.

Thanks for sharing this library!

@maxall41
Copy link
Owner

maxall41 commented Sep 14, 2024

I prefer keeping the struct variables atomic, so I modified the PR to add the Chain ID to the Residue struct instead of customizing the name. For rust-sasa-python I do think the residue level result should return a tuple as you mentioned, so I will update that to return a tuple in the format: ({CHAIN_ID}_{RESIDUE_NAME}_{RESIDUE_INDEX},SASA). Glad you found the library useful!

@maxall41 maxall41 merged commit 404163a into maxall41:main Sep 14, 2024
2 checks passed
@maxall41
Copy link
Owner

This feature is now available as part of rust-sasa-python 0.1.1 (https://pypi.org/project/rust-sasa-python/#files)
Docs: https://github.com/maxall41/rust-sasa-python/blob/main/DOCS.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants