Association Filters

[jonmifsud]

Adds support for Association Filters when using the Association UI. The filters are provided through the symphony core in javascript, and are sent through ajax requests for data when using autocomplete.

[nitriques]

Should use === . Always.

[nitriques]

Great job! I do not want to be mean, but I've reviewed your code ;)

[jonmifsud]

Thanks actually I was expecting more changes. I'll try run update them today/tomorrow.

[nitriques]

Thanks!

[nathanhornby]

Hey @nitriques - do you run a code reviewing service? Could do with a more involved jshint replacement :)

[nitriques]

do you run a code reviewing service?

Nope! But we do use scrutinizer for the core, but results are mitigated because we did not used composer before. Should be better since we start using it.

As for jshint, I did not found any good service for it, except travis-ci (which could run a grunt task)...

If you want to send a PR with a configured jshint task, I would put it on travis for you ;)

[nilshoerrmann]

I'm not up-to-date with the Symphony core development: is there anything needed on that side to make this work or can we just pull this in?

@jonmifsud: Would you mind updating your pull request based on @nitriques comments? Thanks!

[jonmifsud]

Been planning to for a while. I'm a bit tight these next couple of days,
I'll do it as soon as I have a couple of minutes to spare.

On Thu, 2 Apr 2015 at 14:08 Nils Hörrmann [email protected] wrote:

I'm not up-to-date with the Symphony core development: is there anything
needed on that side to make this work or can we just pull this in?

@jonmifsud https://github.com/jonmifsud: Would you mind updating your
pull request based on @nitriques https://github.com/nitriques comments?
Thanks!

—
Reply to this email directly or view it on GitHub
#44 (comment)
.

[nilshoerrmann]

Cool, thanks!

[nitriques]

@nilshoerrmann If you could test it, it would be nice ;)

[nilshoerrmann]

That was my plan ;)

[nitriques]

Thanks Nils!