Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New pages: DOMMatrix multiply(), multiplySelf(), and preMultiplySelf() #37185

Merged
merged 14 commits into from
Jan 10, 2025
Merged

New pages: DOMMatrix multiply(), multiplySelf(), and preMultiplySelf() #37185

merged 14 commits into from
Jan 10, 2025

Conversation

estelle
Copy link
Member

@estelle estelle commented Dec 11, 2024

@estelle estelle requested a review from a team as a code owner December 11, 2024 18:51
@estelle estelle requested review from wbamberg and removed request for a team December 11, 2024 18:51
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 11, 2024
@estelle estelle marked this pull request as draft December 11, 2024 19:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

Preview URLs

Flaws (18)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/DOMMatrix
Title: DOMMatrix
Flaw count: 7

  • macros:
    • /en-US/docs/Web/API/DOMMatrix/scaleSelf does not exist
    • /en-US/docs/Web/API/DOMMatrix/scale3dSelf does not exist
    • /en-US/docs/Web/API/DOMMatrix/rotateAxisAngleSelf does not exist
    • /en-US/docs/Web/API/DOMMatrix/rotateFromVectorSelf does not exist
    • /en-US/docs/Web/API/DOMMatrix/fromFloat32Array does not exist
    • and 2 more flaws omitted

URL: /en-US/docs/Web/API/DOMMatrixReadOnly
Title: DOMMatrixReadOnly
Flaw count: 10

  • macros:
    • /en-US/docs/Web/API/DOMMatrixReadOnly/rotateAxisAngle does not exist
    • /en-US/docs/Web/API/DOMMatrixReadOnly/rotate does not exist
    • /en-US/docs/Web/API/DOMMatrixReadOnly/rotateFromVector does not exist
    • /en-US/docs/Web/API/DOMMatrixReadOnly/scale3d does not exist
    • /en-US/docs/Web/API/DOMMatrixReadOnly/scaleNonUniform does not exist
    • and 5 more flaws omitted

URL: /en-US/docs/Web/API/DOMMatrixReadOnly/multiply
Title: DOMMatrixReadOnly: multiply() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/DOMMatrixReadOnly/preMultiply does not exist

(comment last updated: 2025-01-10 19:12:13)

@estelle estelle marked this pull request as ready for review December 11, 2024 20:07
@estelle estelle changed the title New files: DOMMatrix.multiply() New pages: DOMMatrix multiply(), multiplySelf(), and preMultiplySelf() Dec 11, 2024
wbamberg
wbamberg reviewed Jan 9, 2025
View reviewed changes
files/en-us/web/api/dommatrix/multiplyself/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/dommatrix/multiplyself/index.md Outdated
Comment on lines 18 to 19
DOMMatrix.multiplySelf( )
DOMMatrix.multiplySelf( otherMatrix )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't generally have these spaces in the brackets.

files/en-us/web/api/dommatrix/multiplyself/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/dommatrix/multiplyself/index.md Outdated

### Parameters

- `otherMatrix`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional

files/en-us/web/api/dommatrix/premultiplyself/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/dommatrix/premultiplyself/index.md Outdated

### Parameters

- `otherMatrix`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional

files/en-us/web/api/dommatrixreadonly/multiply/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/dommatrixreadonly/multiply/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/dommatrixreadonly/multiply/index.md Outdated
Comment on lines 18 to 19
DOMMatrixReadOnly.multiply( )
DOMMatrixReadOnly.multiply( otherMatrix )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces

files/en-us/web/api/dommatrixreadonly/multiply/index.md Outdated

### Parameters

- `otherMatrix`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional

@estelle estelle requested a review from wbamberg January 10, 2025 07:48
wbamberg
wbamberg approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks Estelle!

@wbamberg wbamberg merged commit 5e70364 into main Jan 10, 2025
10 checks passed
@wbamberg wbamberg deleted the multiply branch January 10, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @wbamberg