-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark #15
Open
PHS-Meantrix
wants to merge
28
commits into
JOSS
Choose a base branch
from
benchmark
base: JOSS
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Benchmark #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make bench mark scripts
make full bench mark results
update paper with performance improvements
make statments of benchmark and choices
fix returned table put seed
update desc
fix astar calc
update message
update corrp documentation
update doc with example
make documentation update fix vignette on desc
fix vignettes
export corrplot and update readme
corr_fun
update error message
update documentation
udpate documentation in corr_rm
correct documentation format
make ptest for pps
make assert_required_argument
make sys.call correct for assert_req_arg
fix assert when lazy eval
make ptest for pss optional
update documentation end
make more msg on the best_acca sil_acca and acca
update NEWS
This was
linked to
issues
Jan 10, 2025
update vignettes
make contibution md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
0.6.0
VignetteBuilder: knitr
to DESCRIPTIONAstar
method.energy::dcorT.test
. Also, change the data used in the paper.Methods Added
set_arguments
: Assigns provided arguments from theargs_list
to the parent environment. If an argument is inside the arguments of the methods that calculate statistics, it assigns it on the parent environment, and removes the argument from the list.assert_required_argument
: Ensures that a required argument is provided. If the argument is missing, it throws an error with a clear message.Methods Altered
p.value
,comp
, "alternative", "num.s", "rk") of methods:.corlm
,.cramersvp
,.dcorp
,.corperp
,.micorp
,.uncorp
,.corpps
..corpps
method to support p-value testing (p-test
), which is disabled by default due to its slow performance. Whenp-test
is not performed, theisig
value is set toNA
.p-test
can be run assigning an elementptest = TRUE
topps.args
argument.Documentation
corrp
by including examples, refining the pair type section with additional details and references, and providing a more comprehensive explanation of the output format and its interpretation.corr_rm
by adding examples and providing a clearer explanation of thec
parameter.acca
,best_acca
,corrp
,corr_rm
,corr_matrix
,corr_fun
,ptest
,sil_acca
.