Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark #15

Open
wants to merge 28 commits into
base: JOSS
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
ae0144d
Document performance and benchmarks #13
PHS-Meantrix Oct 28, 2024
d3e9e4a
Document performance and benchmarks #13
PHS-Meantrix Oct 30, 2024
3b76b26
Document performance and benchmarks #13
PHS-Meantrix Oct 30, 2024
56725b5
Document performance and benchmarks #13
PHS-Meantrix Nov 1, 2024
b3514da
Document performance and benchmarks #13
PHS-Meantrix Nov 1, 2024
4c8d40c
Document performance and benchmarks #13
PHS-Meantrix Jan 7, 2025
c9d363c
Document performance and benchmarks #13
PHS-Meantrix Jan 8, 2025
2c4101d
Document performance and benchmarks #13
PHS-Meantrix Jan 8, 2025
87de5e9
Document performance and benchmarks #13
PHS-Meantrix Jan 8, 2025
4240c0c
Document performance and benchmarks #13
PHS-Meantrix Jan 8, 2025
6513712
General comments for review #27
PHS-Meantrix Jan 8, 2025
5f54645
General comments for review #27
PHS-Meantrix Jan 8, 2025
2af1634
General comments for review #27
PHS-Meantrix Jan 9, 2025
540e8d0
General comments for review #27
PHS-Meantrix Jan 9, 2025
1da1215
General comments for review #27
PHS-Meantrix Jan 9, 2025
639755d
General comments for review #27
PHS-Meantrix Jan 9, 2025
d564f1a
General comments for review #27
PHS-Meantrix Jan 9, 2025
12f03a2
General comments for review #27
PHS-Meantrix Jan 9, 2025
6732c58
General comments for review #27
PHS-Meantrix Jan 9, 2025
32c9668
General comments for review #27
PHS-Meantrix Jan 10, 2025
61c2214
General comments for review #27
PHS-Meantrix Jan 10, 2025
ca2369a
General comments for review #27
PHS-Meantrix Jan 10, 2025
aaaeeb2
General comments for review #27
PHS-Meantrix Jan 10, 2025
f1ad814
General comments for review #27
PHS-Meantrix Jan 10, 2025
f7eb8b6
General comments for review #27
PHS-Meantrix Jan 10, 2025
d06ad50
General comments for review #27
PHS-Meantrix Jan 10, 2025
6550e28
General comments for review #27
PHS-Meantrix Jan 10, 2025
a1a7218
General comments for review #27
PHS-Meantrix Jan 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
General comments for review #27
make more msg on the best_acca sil_acca and acca
  • Loading branch information
PHS-Meantrix committed Jan 10, 2025
commit f7eb8b68cc519e377797a9f9db5cab5ffebc76d1
4 changes: 3 additions & 1 deletion R/acca.R
Original file line number Diff line number Diff line change
@@ -41,7 +41,9 @@
#'
#' @export
#'
acca <- function(m, ...) {
acca <- function(m, k, ...) {
assert_required_argument(m, "The 'm' argument must be a cmatrix object, which is the output from corr_matrix function, or it must be a matrix.")
assert_required_argument(m, "The 'k' argument must be the number of number of clusters considered.")
UseMethod("acca", m)
}

1 change: 1 addition & 0 deletions R/best_acca.R
Original file line number Diff line number Diff line change
@@ -44,6 +44,7 @@
#' @export
#'
best_acca <- function(m, ...) {
assert_required_argument(m, "The 'm' argument must be a cmatrix object, which is the output from corr_matrix function, or it must be a matrix.")
UseMethod("best_acca", m)
}

6 changes: 4 additions & 2 deletions R/sil_acca.R
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
#' of interpretation and validation of consistency within acca clusters of data.
#'
#' @param acca \[\code{acca_list(1)}]\cr Acca clustering results from \code{\link{acca}}
#' @param m \[\code{matrix(1)}]\cr correlation matrix from \code{\link{corr_matrix}}.
#' @param m \[\code{cmatrix(1)|matrix(1)}]\cr correlation matrix from \code{\link{corr_matrix}}.
#' By default the distance matrix(dist) used in this method is given by `dist = 1 - m`.
#' @param ... Additional arguments.
#'
@@ -36,7 +36,9 @@
#'
#' @export
#'
sil_acca <- function(acca, ...) {
sil_acca <- function(acca, m, ...) {
assert_required_argument(acca, "The 'acca' argument must be a acca_list object, which is the output from acca function, or it must be a list.")
assert_required_argument(m, "The 'm' argument must be a cmatrix object, which is the output from corr_matrix function or it must be a matrix.")
UseMethod("sil_acca", acca)
}

6 changes: 3 additions & 3 deletions man/acca.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions man/sil_acca.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading