KH-392: Improve Disbursement report indicators #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuisson
reviewed
Jan 30, 2024
| @@ -73,7 +73,7 @@ SELECT | |||
| AND o_f.concept_id = ( | |||
| SELECT concept_id | |||
| FROM concept | |||
| WHERE uuid LIKE '758b9dd8-b6d0-4ac2-b245-0e7bffb4693a' | |||
| WHERE uuid LIKE 'c158e3b2-edf9-4e0e-9e95-d36de1a51527' | |||
There was a problem hiding this comment.
Shouldn't this be a config point?
There was a problem hiding this comment.
There's very many of these for the moment because of the wide requirements of the report. Is this a report we intend to re-use with other instances, or is it quite OZ Kh specific in which case I simply use UUIDs directly.
There was a problem hiding this comment.
Good point. It's very Oz Kh specific indeed.
rbuisson
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://mekomsolutions.atlassian.net/browse/KH-392