Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust the docs to the current Orchestrator functionality #2499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheMeaningfulEngineer
Copy link
Contributor

@TheMeaningfulEngineer TheMeaningfulEngineer commented Nov 27, 2024

Tickets: MEN-6996 MEN-7016 CE-447

Examples work once mendersoftware/mender-orchestrator-update-interfaces#7 is merged

Copy link
Contributor

@estenberg estenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, do you know how docs gets merged to stable these days? This is great to have in master for now and iterate over, but we should not merge it into the stable / default docs site.

A few nitpicks here, overall:

  • Names are Capital Case. For example, Mender Client, Orchestrator, Manifest, Artifact, etc.
  • We need to define such new concepts clearly (one sentence) and add them to Taxonomy.
  • Separate examples from Concepts
  • There are some unrelated changes included in the PR

09.Add-ons/05.Orchestrator/docs.md Outdated Show resolved Hide resolved
09.Add-ons/05.Orchestrator/docs.md Outdated Show resolved Hide resolved
09.Add-ons/05.Orchestrator/docs.md Outdated Show resolved Hide resolved
09.Add-ons/05.Orchestrator/docs.md Outdated Show resolved Hide resolved
09.Add-ons/05.Orchestrator/docs.md Show resolved Hide resolved



### Update interface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interface.

By the way, didn't we rename this to just "Interface" now? (drop Update)? Check the Epic.. there are at least some tasks for that.

Also should go in Taxonomy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, actually it's not done but tracked here: https://northerntech.atlassian.net/browse/MEN-7505

I guess you can use the old name for now then, until that task is done. Up to you.

09.Add-ons/05.Orchestrator/docs.md Outdated Show resolved Hide resolved
09.Add-ons/05.Orchestrator/docs.md Outdated Show resolved Hide resolved
@@ -24,7 +24,7 @@ mkfifo /data/mender/dump
mender-snapshot dump > /data/mender/dump
```

Then, back to the shell on the host where you have the variables form the Get Started guide, run:
The last command will not terminate, but will wait for you to execute commands from the host. So back in the shell on the host where you have the variables form the Get Started guide, run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would split to separate PR.

@@ -36,6 +36,8 @@ mender-artifact write rootfs-image \
-f rootfs.ext4
```

While the command is running, you should see a progress bar in the device window.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would split to separate PR.

@lluiscampos
Copy link
Contributor

First off, do you know how docs gets merged to stable these days? This is great to have in master for now and iterate over, but we should not merge it into the stable / default docs site.

Then we should merge this into a feature branch 👌

@michaelntech
Copy link
Member

Found a few small typos to fix.
Two things to watch: not to use 'hosted' Mender unnecessarily, by default just say 'Mender' unless the instruction is exclusively for the hosted offering. And when it is used, 'hosted' should be lowercase – hosted Mender vs. on-premise.

Tickets: MEN-6996 MEN-7016 CE-447

Signed-off-by: Alan <[email protected]>
Signed-off-by: Kristian Amlie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants