Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add model name in the kubernetesResource struct for return the model name with the kind and count in summary api #367

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

amitamrutiya
Copy link
Contributor

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Jan 15, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@@ -14,6 +14,7 @@ type KubernetesResource struct {
ID string `json:"id" gorm:"primarykey"`
APIVersion string `json:"apiVersion" gorm:"index"`
Kind string `json:"kind" gorm:"index"`
Model string `json:"model" gorm:"index"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has Meshery Database been updated with this new column?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@amitamrutiya amitamrutiya Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, This PR depends on this PR -> meshery/meshery#13265 where I added the logic for the adding new column called model in the kubernetes_resources table.

@leecalcote leecalcote merged commit 8752cec into meshery:master Jan 16, 2025
3 of 4 checks passed
Copy link

welcome bot commented Jan 16, 2025

Thanks for your contribution to the Meshery community! 🎉
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

Shows a black logo in light color mode and a white one in dark color mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants