Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Markdown rendering from Text::MultiMarkdown to CommonMark #2894

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

ilmari
Copy link
Contributor

@ilmari ilmari commented Apr 28, 2023

Custom rendering function to add id attribute to headings.

Fixes #2312

Copy link
Member

@haarg haarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

We'll need to wait to merge this until we can change our deployments to include libcmark. It also looks like it needs to get installed in CI.

lib/MetaCPAN/Web/RenderUtil.pm Outdated Show resolved Hide resolved
cpanfile.snapshot Outdated Show resolved Hide resolved
@ilmari ilmari force-pushed the markdown-commonmark branch 2 times, most recently from bfddd9c to 5a210bb Compare April 28, 2023 12:46
@ilmari
Copy link
Contributor Author

ilmari commented Apr 28, 2023

According to the docs I should be able to use sudo apt install libcmark-dev, but it fails with:

Run sudo apt install libcmark-dev
  sudo apt install libcmark-dev
  shell: sh -e {0}
/__w/_temp/3da801c7-faa1-4b90-90e5-c299fa68d890.sh: 1: sudo: not found
Error: Process completed with exit code 127.

@oalders
Copy link
Member

oalders commented Apr 28, 2023

The docker container has no sudo, so you can omit that from the command.

@ilmari ilmari force-pushed the markdown-commonmark branch 6 times, most recently from bbcd61d to aed87be Compare April 28, 2023 15:06
haarg
haarg previously approved these changes Apr 30, 2023
@haarg haarg marked this pull request as draft April 30, 2023 16:03
@haarg
Copy link
Member

haarg commented Apr 30, 2023

The content of this looks good. I've marked it as draft so that it doesn't get merged yet, until we can get the front end switched over to our new systems.

@ilmari ilmari force-pushed the markdown-commonmark branch from aed87be to 2d23d04 Compare July 22, 2023 20:21
@ilmari ilmari force-pushed the markdown-commonmark branch from 2d23d04 to 79767ab Compare February 22, 2024 14:44
@haarg haarg marked this pull request as ready for review March 25, 2024 00:41
@ilmari ilmari force-pushed the markdown-commonmark branch from 4c4c19c to 7b3fac8 Compare March 25, 2024 11:47
Custom rendering function to add `id` attribute to headings.

Fixes metacpan#2312
@ilmari ilmari force-pushed the markdown-commonmark branch from 7b3fac8 to eae0e33 Compare April 25, 2024 10:14
@haarg haarg enabled auto-merge April 25, 2024 10:15
@haarg haarg merged commit 662689b into metacpan:master Apr 25, 2024
5 checks passed
@ilmari ilmari deleted the markdown-commonmark branch April 25, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown not rendering correctly
3 participants