split table of contents from pod and style statically #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than calculate the documented name, associated module, and associated pod file in the controller, do it in the API. Currently, this relies on the requested pod file to calculate, which it probably shouldn't. But preserve the behavior and pass along the requested name to be used in the calculation.
Create a Pod API module that fetches HTML for Pod and filters it. Convert the Pod and Pod2HTML controllers to use it.
Split the index from the rest of the pod content, allowing it to be templated differently. This allows its markup to be included with the static content, rather than being assembled in javascript. This should make it easier to format it differently in the future, and should also fix the scroll position changing on page load.
haarg
force-pushed
the
haarg/split-index
branch
from
d72eb24 to
ae763a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the table of contents from the rest of the pod in the perl code, allowing it to be handled separately in the template. Includes some refactoring to do more work in the API modules.
Fixes #2972