Add docker healthcheck #3203
Merged
Add docker healthcheck #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3203 +/- ##
==========================================
+ Coverage 72.95% 73.08% +0.12%
==========================================
Files 69 69
Lines 2392 2396 +4
Branches 338 338
==========================================
+ Hits 1745 1751 +6
+ Misses 519 517 -2
Partials 128 128
|
haarg
force-pushed
the
haarg/healthcheck
branch
from
6351db8 to
6f82ad2
Compare
Add a /healthcheck end point, returning a simple JSON structure. Use a template rather than normal JSON encoding to ensure that the template engine is working correctly. In the future, this could be extended to check that the API is available, but for now a simple check that just the web server is running is good enough.
haarg
force-pushed
the
haarg/healthcheck
branch
from
6f82ad2 to
b7b7d10
Compare
oalders
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a healthcheck end point doing some rudimentary work that can be checked.
Adds health checks to the docker containers. These will be used by docker-compose. Kubernetes doesn't use the declared docker health checks, so it won't have any impact on production.