Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Release v1.9.2 #843

Merged
merged 1 commit into from
Jan 7, 2025
Merged

🚀 Release v1.9.2 #843

merged 1 commit into from
Jan 7, 2025

Conversation

peppi-lotta
Copy link
Member

What this PR does / why we need it: 1.9.2 patch release

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2025
@peppi-lotta
Copy link
Member Author

/retest

@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@mquhuy
Copy link
Member

mquhuy commented Jan 7, 2025

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@adilGhaffarDev
Copy link
Member

LGTM

tuminoid
tuminoid reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@adilGhaffarDev
Copy link
Member

/hold
lets add this PR too in release notes: #803
it just got merged

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
@peppi-lotta
🚀 Release v1.9.2
7a10a65 
Signed-off-by: peppi-lotta <[email protected]>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@adilGhaffarDev
Copy link
Member

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
@kashifest
Copy link
Member

is this good to go in? Shall I override the tests @adilGhaffarDev

@adilGhaffarDev
Copy link
Member

is this good to go in? Shall I override the tests @adilGhaffarDev

yes good to go in

@kashifest
Copy link
Member

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
Integration tests is not needed here (wont test anything here)

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
Integration tests is not needed here (wont test anything here)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit cbde5db into metal3-io:main Jan 7, 2025
11 checks passed
@metal3-io-bot metal3-io-bot deleted the release-notes-1.9.2 branch January 7, 2025 11:23
@metal3-io-bot metal3-io-bot added this to the IPAM - v1.10 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
IPAM - v1.10
Development

Successfully merging this pull request may close these issues.
6 participants
@peppi-lotta @mquhuy @adilGhaffarDev @metal3-io-bot @kashifest @tuminoid