Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token_type filter added in search_asset rpc method #233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

token_type filter added in search_asset rpc method #233

wants to merge 2 commits into from

Conversation

AhzamAkhtar
Copy link
Contributor

  1. Types of filters that are added in search_assets function are
  • Fungible
  • NonFungible
  • Compressed
  • Nft
  • All
  1. Search_asset rpc call skipping fungible_assets bug fixed
  2. Not able to search for fungible asset using specific owner_address in search_asset bug fixed
  3. Added validation errors and fixed search_assets compatibility issues
  • owner_type and token_type parameter can't be use together
  • In search_assets, SearchAssetQuery doesn't support interface fixed.
  • token_type filter should only be used using owner_address
  • token_type filter can't be used with interface
  1. Tests

kespinola
kespinola requested changes Jan 13, 2025
View reviewed changes
digital_asset_types/src/dao/extensions/asset.rs Outdated Show resolved Hide resolved
digital_asset_types/src/dao/mod.rs Outdated Show resolved Hide resolved
@AhzamAkhtar @kespinola
Search assets by token_type
1ad9ba3 
Add token_type to search asset filter. Apply conditional filters on
database queries based on token_type.
@kespinola kespinola force-pushed the das-51-search-asset-token-type-filter-rebase branch from e51e97f to 1ad9ba3 Compare January 13, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nagaprasadvr Nagaprasadvr Nagaprasadvr left review comments

@kespinola kespinola kespinola approved these changes

@danenbm danenbm Awaiting requested review from danenbm

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AhzamAkhtar @kespinola @danenbm @Nagaprasadvr