Bump rails #10
Open
Bump rails #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump rails to 5.0.7 Bump ruby to 2.6 Correct tests and usage Correct HAML notation for Javascript Add pusher double to ensure jasmine test pass
- Correct cucumber issues - Convert `sign_in :bypass => true` to `bypass_sign_in` - Convert `render nothing: true, status: 404` to `head :not_found`
- Remove coffee scripts - Remove specs with no tests
This reverts commit a4d87e6c191e49ad0ca49281e11134db9fe0848a.
The agency tests were missing the stub of a resume upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the version of rails to 5.0.7.1 and ruby to version 2.6.1.
Also adds the initial implementation of some of the javascript components using react using tsx