src: apply some fixes #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the `%u` format specifier for printing `uint32_t`. - Cast the right-hand side of the condition of the `for` loop to `uint8_t` where it was implicitly promoted to `int`. - Use `int` variable for `getchar()` since it can return `EOF` (`-1`) to indicate an error, `char` cannot hold negative integers. - Use `EOF` instead of `-1` to be idiomatic.
mevdschee
reviewed
Dec 2, 2023
| @@ -164,7 +164,7 @@ void rotateBoard(uint8_t board[SIZE][SIZE]) | |||
| uint8_t tmp; | |||
| for (i = 0; i < n / 2; i++) | |||
| { | |||
| for (j = i; j < n - i - 1; j++) | |||
| for (j = i; j < (uint8_t)(n - i - 1); j++) | |||
There was a problem hiding this comment.
This inline construct may be confusing for beginning programmers.
There was a problem hiding this comment.
What alternatives do you suggest? Should I assign the expression to a variable?
ulcuber
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%uformat specifier for printinguint32_t.forloop touint8_twhere it was implicitly promoted toint.intvariable forgetchar()since it can returnEOF(-1) to indicate an error,charcannot hold negative integers.EOFinstead of-1to be idiomatic.