New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory base type in WASI wrapper rust example #36

Merged

ainozaki merged 1 commit into mewz-project:main from fgh1999:fix-mem-base-addr

Jul 5, 2024

Contributor

fgh1999 commented Jul 1, 2024

I used i32 as the return type for memory_base... well, that's wrong and can cause segmentation fault in some cases.


          Fix memory base type in WASI wrapper rust example

1cccc27

ainozaki self-requested a review

July 2, 2024 11:44

Contributor

ainozaki commented Jul 5, 2024

Thank you for the fix! LGTM 👍
Btw, Wasker might need to fix the issue with handling raw pointers...

ainozaki approved these changes

View reviewed changes

ainozaki merged commit bacb755 into mewz-project:main

2 checks passed

fgh1999 deleted the fix-mem-base-addr branch

July 5, 2024 17:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet