Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Exclusions and ExclusionsBuilder to usage of nested class #512

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

mfvanek
Copy link
Owner

@mfvanek mfvanek commented Nov 25, 2024

Closes #481

  1. ExclusionsBuilder class was removed
  2. Exclusions class was significantly refactored

@mfvanek mfvanek added the breaking change Pull requests that breaks backward compatibility label Nov 25, 2024
@mfvanek mfvanek added this to the 0.14.0 milestone Nov 25, 2024
@mfvanek mfvanek marked this pull request as ready for review November 25, 2024 19:17
@mfvanek mfvanek merged commit 1721b6b into master Nov 25, 2024
6 checks passed
@mfvanek mfvanek deleted the feature/refactor-exclusions branch November 25, 2024 19:41
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (05840d5) to head (785e856).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #512   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity      1054      1010   -44     
===========================================
  Files            166       165    -1     
  Lines           2215      2128   -87     
  Branches         152       150    -2     
===========================================
- Hits            2215      2128   -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Pull requests that breaks backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider to refactor Exclusions and ExclusionsBuilder to usage of nested class
1 participant