Fixed problem with not finding new issues in SonarQube 5.4/5.5 and

Gradle build

dev.sh

@@ -4,7 +4,7 @@
 
 mvn clean install || exit 1
 
-PLUGIN_VERSION=1.1.2
+PLUGIN_VERSION=1.1.4-SNAPSHOT
 PLUGIN_FILE="./target/sonar-bitbucket-plugin-$PLUGIN_VERSION.jar"
 
 [ ! -f $PLUGIN_FILE ] && { echo "Plug-in JAR file not found: $PLUGIN_FILE"; exit 1; }

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>ch.mibex.bitbucket</groupId>
     <artifactId>sonar-bitbucket-plugin</artifactId>
-    <version>1.1.2</version>
+    <version>1.1.4-SNAPSHOT</version>
     <packaging>sonar-plugin</packaging>
     <name>Sonar Bitbucket Cloud Plugin</name>
 

src/main/scala/ch/mibex/bitbucket/sonar/client/BitbucketClient.scala

@@ -207,8 +207,9 @@ class BitbucketClient(config: SonarBBPluginConfig) extends BatchComponent {
       .accept(MediaType.APPLICATION_JSON)
       .`type`(MediaType.APPLICATION_JSON)
       .get(classOf[String])
+
     val page = JsonUtils.mapFromJson(response)
-    val nextPageStart = page.get("next").map(p => pageNr + 1)
+    val nextPageStart = page.get("next").map(_ => pageNr + 1)
     (nextPageStart, f(page))
   }
 

src/main/scala/ch/mibex/bitbucket/sonar/review/ReviewCommentsCreator.scala

@@ -78,9 +78,9 @@ class ReviewCommentsCreator(projectIssues: ProjectIssues,
   }
 
   private def processIssues(pullRequest: PullRequest, reviewResults: PullRequestReviewResults) = {
-    val newIssues = collectNewIssuesInProject()
-    val issuesOnChangedLines = issuesOnChangedLinesFilter.filter(pullRequest, newIssues)
-    debugLogIssueStatistics(newIssues, issuesOnChangedLines)
+    val issues = collectIssuesInProject() // we have to
+    val issuesOnChangedLines = issuesOnChangedLinesFilter.filter(pullRequest, issues)
+    debugLogIssueStatistics(issues, issuesOnChangedLines)
     val onlyIssuesWithMinSeverity = issuesOnChangedLines
       .filter(i => SonarUtils.isSeverityGreaterOrEqual(i, pluginConfig.minSeverity()))
     val commentsToBeAdded = new mutable.HashMap[String, mutable.Map[Int, StringBuilder]]()
@@ -112,10 +112,10 @@ class ReviewCommentsCreator(projectIssues: ProjectIssues,
     commentsToBeAdded.toMap
   }
 
-  private def debugLogIssueStatistics(newIssues: Seq[Issue], issuesOnChangedLines: Seq[Issue]) {
+  private def debugLogIssueStatistics(issues: Seq[Issue], issuesOnChangedLines: Seq[Issue]) {
     if (logger.isDebugEnabled) {
-      logger.debug(LogUtils.f(s"Found ${newIssues.size} new issues:"))
-      newIssues foreach { i =>
+      logger.debug(LogUtils.f(s"Found ${issues.size} issues and ${issues.filter(_.isNew)} of them are new:"))
+      issues foreach { i =>
         logger.debug(LogUtils.f(s"  - ${i.componentKey()}:${i.line()}: ${i.message()}"))
       }
       logger.debug(LogUtils.f(s"And ${issuesOnChangedLines.size} of these are on changed or new lines:"))
@@ -145,14 +145,14 @@ class ReviewCommentsCreator(projectIssues: ProjectIssues,
     )
   }
 
-  private def collectNewIssuesInProject() =
+  private def collectIssuesInProject() =
     // with sonar.analysis.mode=preview and sonar.analysis.mode=issues I always get all issues here
     // although I only request new ones; this should be changed with SonarQube 5.4; until then, we still have to filter
     // issues on changed lines only by using the diff from Bitbucket
+    // UPDATE: SonarQube 5.5 does not report any issues at all when filtering for new issues with issues.filter(_.isNew)
     projectIssues
       .issues()
       .asScala
-      .filter(_.isNew)
       .toSeq
 
 }