Fix

microsoft · Sep 23, 2024 · 9f9fdc5 · 9f9fdc5
1 parent f8a8ba0
commit 9f9fdc5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/...om/microsoft/applicationinsights/agent/internal/keytransaction/KeyTransactionSampler.java b/...om/microsoft/applicationinsights/agent/internal/keytransaction/KeyTransactionSampler.java
@@ -84,6 +84,9 @@ public SamplingResult shouldSample(
     SamplingResult result =
         fallback.shouldSample(parentContext, traceId, name, spanKind, attributes, parentLinks);
 
+    if (existingKeyTransactions.isEmpty() && startKeyTransactions.isEmpty()) {
+      return result;
+    }
     return new TransactionSamplingResult(
         existingKeyTransactions, startKeyTransactions, endKeyTransactions, result);
   }

diff --git a/...ing/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/Samplers.java b/...ing/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/Samplers.java
@@ -55,7 +55,7 @@ public static Sampler getSampler(
       // as
       // it will ensure consistent traces, however it does not accurately compute item counts, since
       // item counts are not propagated in trace state (yet)
-      return Sampler.parentBasedBuilder(sampler).build();
+      sampler = Sampler.parentBasedBuilder(sampler).build();
     }
 
     if (KeyTransactionConfigSupplier.KEY_TRANSACTIONS_ENABLED) {