Log which db stores are created and deleted #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliranek1
previously approved these changes
Jan 12, 2024
|
@microsoft-github-policy-service agree |
thomastay
reviewed
Jan 13, 2024
| dbName, | ||
| deletedStores, | ||
| oldVersion: event.oldVersion, | ||
| newVersion: event.newVersion ?? undefined, |
There was a problem hiding this comment.
what is the use of doing ?? undefined? Doesn't this just return undefined?
|
Yes, it'll turn null into undefined. I didn't want to handle null
differently for logging the newVersion
…On Fri, Jan 12, 2024 at 4:37 PM Thomas Tay ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/IndexedDbProvider.ts
<#57 (comment)>
:
> }
});
- this.logWriter.log(`Deleted all object stores`, { dbName });
+ this.logWriter.log(`Deleted all object stores`, {
+ dbName,
+ deletedStores,
+ oldVersion: event.oldVersion,
+ newVersion: event.newVersion ?? undefined,
what is the use of doing ?? undefined? Doesn't this just return undefined?
—
Reply to this email directly, view it on GitHub
<#57 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGAQVC7B4ZL2I4AZRMRWR3YOHJMRAVCNFSM6AAAAABBYYFAWGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMJZGQ2TANBVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding these logging lines to make it easier to tell what stores were deleted or created during a db upgrade