Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Fix loc pipeline to send downloaded localized files to TDBuild upon retry after failure #36766

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Jan 9, 2025

Summary of the Pull Request

Root cause
The root cause of the issue is that during the execution of the localization pipeline, some already localized files were downloaded. However, when the service failed and triggered a retry, the regex used to search for all resource files also included the downloaded files.
this pipeline caused the issue: https://microsoft.visualstudio.com/Dart/_build/results?buildId=112645818&view=results
The request failed, as shown in the image below:
image
Here, localized files start to be incorrectly used by TDBuild.
image

ICM: https://portal.microsofticm.com/imp/v5/incidents/details/576641069/summary

PR fix
This fix addresses the issue by excluding the output folder from the source path regex.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@lei9444 lei9444 requested a review from a team as a code owner January 9, 2025 10:03
Copy link

@yeelam-gordon yeelam-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround, looks good.

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great investigation!

@crutkas crutkas merged commit 5ef9187 into main Jan 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants