Skip to content

Commit

Permalink
Added notes to CHANGES.md
Browse files Browse the repository at this point in the history
  • Loading branch information
Kim Laine (HE/HIM) committed Dec 28, 2022
1 parent 998c795 commit 859499e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 4 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,19 @@

### Other Fixes

- Fixed typos [(PR #590)](https://github.com/microsoft/SEAL/pull/590).
- Added $schema to cgmanifest.json [(PR #558)](https://github.com/microsoft/SEAL/pull/558).
- Fixed typos [(PR #512)](https://github.com/microsoft/SEAL/pull/512).
- Fixed typos [(PR #530)](https://github.com/microsoft/SEAL/pull/530).
- Fixed typos [(PR #509)](https://github.com/microsoft/SEAL/pull/509).
- Added missing `const` qualifiers [(PR #556)](https://github.com/microsoft/SEAL/pull/556).
- Added vcpkg installation instructions [(PR #562)](https://github.com/microsoft/SEAL/pull/562).
- Fixed an issue in specific environments where allocation fails without throwing `std::bad_alloc`.
- Fixed comments (C++) and C/.NET wrapper implementation of an exception thrown by `invariant_noise_budget`.

### Major API Changes

- Added new public methods `mod_reduce_xxx(...)` (native) or `ModReduceXxx(...)` (dotnet) to the class `Evaluator`.
- Added new public methods `mod_reduce_xxx(...)` (native) and `ModReduceXxx(...)` (dotnet) to the class `Evaluator`.

## Version 4.0.0

Expand Down
2 changes: 0 additions & 2 deletions native/src/seal/evaluator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1573,7 +1573,6 @@ namespace seal
}

void Evaluator::mod_reduce_to_next_inplace(Ciphertext &encrypted, MemoryPoolHandle pool) const

{
// Verify parameters.
if (!is_metadata_valid_for(encrypted, context_) || !is_buffer_valid(encrypted))
Expand All @@ -1592,7 +1591,6 @@ namespace seal
}

mod_reduce_to_next(encrypted, encrypted, std::move(pool));

#ifdef SEAL_THROW_ON_TRANSPARENT_CIPHERTEXT
// Transparent ciphertext output is not allowed.
if (encrypted.is_transparent())
Expand Down

0 comments on commit 859499e

Please sign in to comment.