Don't fetch deps during build; use submodules #533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Rust docs for our
seal_fhe
Rust wrapper crate, the docs fail to compile because docs.rs builds run in a Docker container that doesn't allow network access during compilation. This means third-party dependencies fail to download and the cmake bails.This change migrates the third party dependencies to be submodules, avoiding the need to fetch them during the build. Rust will blindly package these as source files, so everyone should be happy.
I tested this by building SEAL with every feature enable and compiling tests and benchmarks.