Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #50, Fixes #56, Fixes #58 - Environment Improvements #57

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JacobKnightley
Copy link
Collaborator

@JacobKnightley JacobKnightley commented Jan 25, 2025

This pull request includes several changes to improve the handling of environment libraries and the retry logic within the fabric_cicd module. The most important changes involve adding new dependencies, modifying the invoke method, and refactoring the retry logic.

Dependency Updates:

  • Added fuzzywuzzy and python-levenshtein to environment.yml to handle string matching and distance calculations.

Method Enhancements:

  • Updated invoke method in fabric_cicd/_common/_fabric_endpoint.py to accept additional keyword arguments and handle retry logic more flexibly. [1] [2] [3] [4] [5]

Retry Logic Refactoring:

  • Removed the _handle_retry method and introduced a new handle_retry function to centralize and simplify retry logic. [1] [2] [3]

Environment Publishing:

  • Enhanced the _publish_environment_metadata function to include new steps for updating compute settings, adding and removing libraries, and checking the publish state. [1] [2]
  • Modified the _publish_item method in fabric_workspace.py to support additional parameters and improved logging control. [1] [2] [3] [4]

Fixes #50
Fixes #56
Fixes #58

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/fabric_cicd/_common/_fabric_endpoint.py:251

  • The prepend_message variable should be initialized to an empty string if it is None to avoid TypeError.
prepend_message += " " if prepend_message else ""

src/fabric_cicd/_items/_environment.py Outdated Show resolved Hide resolved
Jacob Knightley and others added 3 commits January 24, 2025 17:30
@JacobKnightley JacobKnightley marked this pull request as ready for review January 26, 2025 01:10
@JacobKnightley JacobKnightley requested a review from a team as a code owner January 26, 2025 01:10
@JacobKnightley JacobKnightley changed the title Update Environment Deployments Fixes #50, Fixes #56, Fixes #58 - Environment Refactor Jan 26, 2025
@JacobKnightley JacobKnightley changed the title Fixes #50, Fixes #56, Fixes #58 - Environment Refactor Fixes #50, Fixes #56, Fixes #58 - Environment Improvements Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant