Activity Indicator Demo: Dynamic start/stop activity button title

[imthath-m]

Platforms Impacted

• iOS
• macOS

Description of changes

Updated title of action button in the settings of ActivityIndicator demo page. The title is now dynamic and changes based on the state of the activity indicators below.

In the iOS demo app, open ActivityIndicator. The button in the second section (Settings) will now read "Stop Activity". If you tap that, the activity indicators below will stop spinning (and also hide if that is enabled) and the button title will change to "Start Activity".

Previously the button was named "Start/Stop Activity" which did not exactly represent the state of the activity indicators below.

Binary change

No change in binary size as the change is only in the iOS demo app.

Verification

• The button title is "Stop Activity" when activity indicators are running
• The button title is "Start Activity" when activity indicators are stopped/hidden

Visual Verification

Before

CleanShot.2024-01-26.at.18.14.22.mp4

After

CleanShot.2024-01-26.at.16.51.59.mp4

Pull request checklist

This PR has considered:

• Light and Dark appearances
• iOS supported versions (all major versions greater than or equal current target deployment version)
• VoiceOver and Keyboard Accessibility
• Internationalization and Right to Left layouts
• Different resolutions (1x, 2x, 3x)
• Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
• iPad Pointer interaction
• SwiftUI consumption (validation or new demo scenarios needed)
• Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

[mischreiber]

Nit: we avoid declaring types for inline variables unless strictly needed. See the specific reference in our style guide at Type Inference | swift-guide (microsoft.github.io)

[imthath-m]

Based on the linked guide, it would still make sense to declare types in such cases. Here Int is not directly used as literal. It is the result of a function firstIndex on another type. So for quick understanding, I think it is helpful to have the type Int specified here.

[mischreiber]

The guide is consistent on this point:

Use type annotation as little as possible when declaring a constant or a variable; instead let the compiler infer the variable type.

Let the compiler infer the type of a constant or variable whenever possible.

The primary exception to this policy is for stored properties; local variables should almost never need a type declared, particularly when they are storing the result of a well-understood method like firstIndex.