fix(workspace-plugin): fail build executor process if generate-api failed #33558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Hotell
force-pushed
the
tools/workspace-plugin/executors/build/fix
branch
from
676b142 to
c3f6183
Compare
Hotell
commented
Jan 8, 2025
tools/workspace-plugin/src/executors/build/__fixtures__/executor/libs/proj/tsconfig.lib.json
Show resolved
Hide resolved
Hotell
commented
Jan 8, 2025
mainframev
reviewed
Jan 9, 2025
mainframev
approved these changes
Jan 9, 2025
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
build executor ends with success even if generate-api executor fails.
This introduces leak into API changes in v9 projects
New Behavior
We fail process if generate-api fails.
Related Issue(s)