feat(react-color-picker): Added transparent option to the AlphaSlider
#33572
+59
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Jan 7, 2025
change/@fluentui-react-color-picker-preview-d36c4ad2-9cc0-4131-bdee-dd557b75c0bb.json
Show resolved
Hide resolved
ValentinaKozlova
force-pushed
the
feat/transparent-option-color-picker
branch
from
5cd6e31 to
242f408
Compare
dmytrokirpa
reviewed
Jan 8, 2025
...ponents/react-color-picker-preview/library/src/components/AlphaSlider/useAlphaSliderState.ts
Outdated
Show resolved
Hide resolved
| const newColor: HsvColor = { ...hsvColor, a: newValue / 100 }; | ||
| setCurrentValue(newValue); | ||
| inputOnChange?.(event); | ||
| onChange?.(event, { type: 'change', event, color: newColor }); | ||
| }); | ||
|
|
||
| const sliderDirection = state.vertical |
There was a problem hiding this comment.
Consider extracting this into a named utility function. This will enhance code readability and simplify unit testing.
There was a problem hiding this comment.
Fixed. I was thinking about moving those functions to the separate files but then I'll need to pass plenty parameters there
There was a problem hiding this comment.
I think pure functions with a few parameters are way better and easier to maintain than inner functions that rely on scope. If you have more than three arguments, it's a good idea to use an object for the parameters.
dmytrokirpa
reviewed
Jan 8, 2025
...ponents/react-color-picker-preview/library/src/components/AlphaSlider/useAlphaSliderState.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
transparentoption to the AlphaSlider. It's the same behavior we have in V8 ColorPicker.Previous Behavior
New Behavior