Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove MenuItem focus on hover #33577

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Jan 7, 2025

In order to be consistent with Combobox/Dropdown/TagPicker on hover/focused states - this PR removes the behaviour of Menu where items are focused on hover even though this seems to be the prevailing pattern with the ARIA working group https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-editor/

image

In order to be consistent with Combobox/Dropdown/TagPicker on
hover/focused states - this PR removes the behaviour of Menu where items
are focused on hover even though this seems to be the prevailing pattern
with the ARIA working group https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-editor/
@github-actions github-actions bot added this to the January Project Cycle Q1 2025 milestone Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
222.703 kB
64.42 kB
222.577 kB
64.396 kB
-126 B
-24 B
react-components
react-components: entire library
1.164 MB
291.227 kB
1.164 MB
291.205 kB
-127 B
-22 B
react-menu
Menu (including children components)
154.048 kB
46.506 kB
153.921 kB
46.481 kB
-127 B
-25 B
react-menu
Menu (including selectable components)
156.729 kB
46.992 kB
156.602 kB
46.968 kB
-127 B
-24 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-avatar
Avatar
49.303 kB
15.815 kB
react-avatar
AvatarGroup
20.106 kB
7.968 kB
react-avatar
AvatarGroupItem
63.447 kB
20.034 kB
react-breadcrumb
@fluentui/react-breadcrumb - package
114.291 kB
31.695 kB
react-components
react-components: Button, FluentProvider & webLightTheme
69.21 kB
20.174 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-datepicker-compat
DatePicker Compat
225.318 kB
63.786 kB
react-dialog
Dialog (including children components)
100.417 kB
30.097 kB
react-overflow
hooks only
12.808 kB
4.819 kB
react-persona
Persona
56.194 kB
17.695 kB
react-popover
Popover
130.294 kB
40.69 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-table
DataGrid
161.034 kB
45.71 kB
react-table
Table (Primitives only)
42.666 kB
13.854 kB
react-table
Table as DataGrid
131.869 kB
36.57 kB
react-table
Table (Selection only)
70.536 kB
19.999 kB
react-table
Table (Sort only)
69.179 kB
19.61 kB
react-tag-picker
@fluentui/react-tag-picker - package
185.227 kB
55.684 kB
react-tags
InteractionTag
15.199 kB
6.157 kB
react-tags
Tag
29.072 kB
9.55 kB
react-tags
TagGroup
82.719 kB
24.524 kB
react-teaching-popover
TeachingPopover
91.711 kB
27.921 kB
react-timepicker-compat
TimePicker
108.525 kB
36.087 kB
react-tree
FlatTree
145.462 kB
41.771 kB
react-tree
PersonaFlatTree
146.15 kB
41.881 kB
react-tree
PersonaTree
142.381 kB
40.703 kB
react-tree
Tree
141.693 kB
40.602 kB
🤖 This report was generated against 384df0ccb4a5324da6daee8f18712ef5a81fa05a

Copy link

github-actions bot commented Jan 7, 2025

Pull request demo site: URL

@@ -0,0 +1,7 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.Badge Mask RTL.chromium.png 4 Changed
Avatar Converged.badgeMask.chromium.png 16 Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants